using basic join for sql query for multiple values

Question

hoping someone can help, I've used search but answers are beyond what we aare covering.

I'm looking to pull up "staff member who looks after property in Glasgow or Aberdeen" using the below code:

SELECT s.fName, s.lName, propertyNo
FROM Staff s, PropertyForRent p
WHERE s.staffNo = p.staffNo 
AND city = 'Glasgow' OR 'Aberdeen';

only Glasgow is being returned ..I've also tried AND which returns nothing. I'm completely new to this so I know I'm missing something very basic.

Answer 1

SELECT s.fName, s.lName, propertyNo
FROM Staff s, PropertyForRent p
WHERE s.staffNo = p.staffNo 
AND (city = 'Glasgow' OR city='Aberdeen');

This can also be rewritten to

SELECT s.fName, s.lName, propertyNo
FROM Staff s, PropertyForRent p
WHERE s.staffNo = p.staffNo 
AND city in('Glasgow', 'Aberdeen');

However, you should use a proper join structure to let the optimizer do its thing

SELECT s.fName, s.lName, propertyNo
FROM Staff s 
INNER JOIN PropertyForRent p ON s.staffNo = p.staffNo 
WHERE (city = 'Glasgow' OR city='Aberdeen');

Answer 2

You have missed the brackets it should be

a AND (b OR c)

Edit and after the OR you have to write city = x again. And you should prefix all of your fields like you do it with s.fName . p.propertyNo and city should also be prefixed.

Answer 3

It's better to use explicit JOINs.

SELECT s.fName, s.lName, propertyNo
FROM Staff AS s
INNER JOIN PropertyForRent AS p
ON s.staffNo = p.staffNo 
AND city IN ('Glasgow', 'Aberdeen')

Answer 4

In SQL, you should give the field name before value same like in many programming languages.

SELECT s.fName, s.lName, propertyNo
FROM Staff s, PropertyForRent p
WHERE s.staffNo = p.staffNo 
AND (p.city = 'Glasgow' OR p.city='Aberdeen');

Answer 5

Have you tried :

city in ('Glasgow', 'Aberdeen');

or

city = 'Glasgow' or city = 'Aberdeen'