Converting an Access Query to SQL Server

Question

I am trying to convert this query to a SQL Server view

SELECT 
    IIF([tblStockMovementsDate] ! [LocationType] = 3, [tblShops] ! [Type], [tblLocationType] ! [LocationTypeDesc]) AS [LocationTypeDesc],
    tblStockMovementsDate.[Location],
    qryAllLocations.[WarehouseName],
    SUM (([tblStockMovementsdate] ! [MovementQtyHangers] + ([tblStockMovementsdate] ! [MovementQtyBoxes] * Iif(Isnull([qryGarmentsPerBox] ! [GarmentsPerBox]), 1, [qryGarmentsPerBox] ! [GarmentsPerBox]))) * [qryUnitPrice] ! [UnitPrice]) AS [TotalValue],
    IIF ([tblShops] ! [Type] = 'Concession', 4, [tblStockMovementsDate] ! [LocationType]) AS [LocationType]
FROM   
    (((((tblStockMovementsDate
INNER JOIN 
    tblLocationType ON tblStockMovementsDate.[LocationType] = tblLocationType.[LocationType])
INNER JOIN 
    qryAllLocations ON tblStockMovementsDate.[Location] = qryAllLocations.[WarehouseRef])
LEFT JOIN 
    qryGarmentsPerBox ON (tblStockMovementsDate.[Location] = qryGarmentsPerBox.[WarehouseRef])
                      AND (tblStockMovementsDate.[StockCode] = qryGarmentsPerBox.[StockCode]))
LEFT JOIN 
    qryUnitPrice ON tblStockMovementsDate.[StockCode] = qryUnitPrice.[StockCode])
LEFT JOIN 
    tblShops ON tblStockMovementsDate.[Location] = tblShops.[ShopRef])
INNER JOIN 
    tblStock ON tblStockMovementsDate.[StockCode] = tblStock.[StockCode]
WHERE  
    ((IIF ([tblShops].[Clearance] = 0, [tblStock].[DeadCode] = 0, [tblStock].[RemoveFromClearance] = 0) ) <> False)
GROUP BY 
    IIF ([tblStockMovementsDate] ! [LocationType] = 3, [tblShops] ! [Type], [tblLocationType] ! [LocationTypeDesc]),
    tblStockMovementsDate.[Location], 
    qryAllLocations.[WarehouseName],
    IIF ([tblShops] ! [Type] = 'Concession', 4, [tblStockMovementsDate] ! [LocationType])
ORDER BY
    IIF ([tblShops] ! [Type] = 'Concession', 4, [tblStockMovementsDate] ! [LocationType]) 

but it won't produce an output, instead I keep getting this error:

Error in list of function arguments: '=' not recognized.
Error in list of function arguments: 'IS' not recognized.
Unable to parse query text.

Any help would be appreciated.

Answer 1

This is a shot in the dark. I did my best to decipher the code you posted originally.

I would recommend getting rid of those nested views. They are going to cause you serious anguish at some point. You will likely have to grab the queries from those views and move that to this query.

Notice how much cleaner this is when you use aliases instead of the Access default of slapping the table in front of every column. I also removed dozens of parenthesis groups that did nothing but make this hard to see. I also converted all your IIF expressions to case expressions since I don't know what version of sql you are using.

SELECT 
    case when smd.LocationType = 3 
        then tblShops.Type 
        else lt.LocationTypeDesc 
    end AS LocTypeDesc
    , smd.Location
    , al.WarehouseName
    , Sum((smd.MovementQtyHangers + (smd.MovementQtyBoxes * Isnull(g.GarmentsPerBox, 1))) * qryUnitPrice.UnitPrice) AS TotalValue
    , case when sh.Type = 'Concession' 
        then 4 
        else smd.LocationType 
    end AS LocType
FROM tblStockMovementsDate smd
INNER JOIN tblLocationType lt ON smd.LocationType = ll.LocationType
INNER JOIN qryAllLocations al ON smd.Location = al.WarehouseRef
LEFT JOIN qryGarmentsPerBox g ON smd.Location = g.WarehouseRef 
                                AND smd.StockCode = g.StockCode
LEFT JOIN qryUnitPrice up ON smd.StockCode = up.StockCode
LEFT JOIN tblShops sh ON smd.Location = sh.ShopRef
INNER JOIN tblStock st ON smd.StockCode = st.StockCode
WHERE tblShops.Clearance <> 0
    OR tblStock.DeadCode <> 0
    OR tblStock.RemoveFromClearance <> 0 
GROUP  BY case when smd.LocationType = 3 then tblShops.Type else lt.LocationTypeDesc end
    , smd.Location
    , al.WarehouseName
    , case when sh.Type = 'Concession' then 4 else smd.LocationType end
order by LocType