How to avoid so many if else statements
Question
I'm implementing a class that scans through the database for data and it displays the data in a table according to what's in a database. However, to cater for all the possible return from the database and constrained by how the JTable displays information, I find my self writing so many if else statements which are prone to error.
package googo.pmms.project2.financialStatement;
import googo.pmms.project2.frameHelper.ReportsModelData;
import java.util.List;
import java.util.Map;
import javax.swing.JTable;
import javax.swing.table.TableRowSorter;
public class TheBalanceSheet implements BalanceSheet {
ReportsModelData model1;
String title;
List<String> tableHeaders;
List<Object> dataBody;
Map<Integer, List<Object>> data;
BalanceSheetUtility bUtility = new BalanceSheetUtility();
public TheBalanceSheet() {
}
public boolean createBalanceSheet(JTable table, String materialDate) {
boolean bs = true;
AssetAccount asset = new AssetAccount(materialDate);
LiabilityEquityAccounts liabEqui = new LiabilityEquityAccounts(materialDate);
if (!asset.isAssetsEmpty()) {
this.setBodyMap(0, asset.mainAssetTitle());
if (!asset.isCurrentAssetsEmpty()) {
this.setBodyMap(1, asset.currentAssetTitle());
this.setBodyMap(2, asset.currentAssets());
this.setBodyMap(3, asset.totalCurrentAssets());
if (!asset.isNonCurrentAssetsEmpty()) {
this.setBodyMap(4, asset.nonCurrentAssetTitle());
this.setBodyMap(5, asset.nonCurrentAssets());
this.setBodyMap(6, asset.totalNonCurrentAssets());
this.setBodyMap(7, this.totalAssets());
if (!liabEqui.isLiabilitiesEmpty()) {
this.setBodyMap(8, liabEqui.mainLiabilitiesEquityTitle());
if (!liabEqui.isCurrentLiabilityEmpty()) {
this.setBodyMap(9, liabEqui.currentLiabilitiesTitle());
this.setBodyMap(10, liabEqui.currentLiabilities());
this.setBodyMap(11, liabEqui.totalCurrentLiabilities());
if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(12, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(13, liabEqui.nonCurrentLiabilities());
this.setBodyMap(14, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(15, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(16, liabEqui.equityTitle());
this.setBodyMap(17, liabEqui.equity());
this.setBodyMap(18, liabEqui.totalEquity());
this.setBodyMap(19, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(12, liabEqui.equityTitle());
this.setBodyMap(13, liabEqui.equity());
this.setBodyMap(14, liabEqui.totalEquity());
this.setBodyMap(15, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(9, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(10, liabEqui.nonCurrentLiabilities());
this.setBodyMap(11, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(12, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(13, liabEqui.equityTitle());
this.setBodyMap(14, liabEqui.equity());
this.setBodyMap(15, liabEqui.totalEquity());
this.setBodyMap(16, this.totalLiabilitiesEquity());
}
} else {
}
}
} else {
this.setBodyMap(4, this.totalAssets());
if (!liabEqui.isLiabilitiesEmpty()) {
this.setBodyMap(5, liabEqui.mainLiabilitiesEquityTitle());
if (!liabEqui.isCurrentLiabilityEmpty()) {
this.setBodyMap(6, liabEqui.currentLiabilitiesTitle());
this.setBodyMap(7, liabEqui.currentLiabilities());
this.setBodyMap(8, liabEqui.totalCurrentLiabilities());
if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(9, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(10, liabEqui.nonCurrentLiabilities());
this.setBodyMap(11, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(12, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(13, liabEqui.equityTitle());
this.setBodyMap(14, liabEqui.equity());
this.setBodyMap(15, liabEqui.totalEquity());
this.setBodyMap(16, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(9, liabEqui.equityTitle());
this.setBodyMap(10, liabEqui.equity());
this.setBodyMap(11, liabEqui.totalEquity());
this.setBodyMap(12, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(6, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(7, liabEqui.nonCurrentLiabilities());
this.setBodyMap(8, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(9, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(10, liabEqui.equityTitle());
this.setBodyMap(11, liabEqui.equity());
this.setBodyMap(12, liabEqui.totalEquity());
this.setBodyMap(13, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(6, liabEqui.equityTitle());
this.setBodyMap(7, liabEqui.equity());
this.setBodyMap(8, liabEqui.totalEquity());
this.setBodyMap(9, this.totalLiabilitiesEquity());
}
}
}
} else if (!asset.isNonCurrentAssetsEmpty()) {
this.setBodyMap(1, asset.nonCurrentAssetTitle());
this.setBodyMap(2, asset.nonCurrentAssets());
this.setBodyMap(3, asset.totalNonCurrentAssets());
this.setBodyMap(4, this.totalAssets());
if (!liabEqui.isLiabilitiesEmpty()) {
this.setBodyMap(5, liabEqui.mainLiabilitiesEquityTitle());
if (!liabEqui.isCurrentLiabilityEmpty()) {
this.setBodyMap(6, liabEqui.currentLiabilitiesTitle());
this.setBodyMap(7, liabEqui.currentLiabilities());
this.setBodyMap(8, liabEqui.totalCurrentLiabilities());
if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(9, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(10, liabEqui.nonCurrentLiabilities());
this.setBodyMap(11, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(12, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(13, liabEqui.equityTitle());
this.setBodyMap(14, liabEqui.equity());
this.setBodyMap(15, liabEqui.totalEquity());
this.setBodyMap(16, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(9, liabEqui.equityTitle());
this.setBodyMap(10, liabEqui.equity());
this.setBodyMap(11, liabEqui.totalEquity());
this.setBodyMap(12, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(6, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(7, liabEqui.nonCurrentLiabilities());
this.setBodyMap(8, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(9, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(10, liabEqui.equityTitle());
this.setBodyMap(11, liabEqui.equity());
this.setBodyMap(12, liabEqui.totalEquity());
this.setBodyMap(13, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(6, liabEqui.equityTitle());
this.setBodyMap(7, liabEqui.equity());
this.setBodyMap(8, liabEqui.totalEquity());
this.setBodyMap(9, this.totalLiabilitiesEquity());
}
}
}
} else if (!liabEqui.isLiabilitiesEmpty()) {
this.setBodyMap(0, liabEqui.mainLiabilitiesEquityTitle());
if (!liabEqui.isCurrentLiabilityEmpty()) {
this.setBodyMap(1, liabEqui.currentLiabilitiesTitle());
this.setBodyMap(2, liabEqui.currentLiabilities());
this.setBodyMap(3, liabEqui.totalCurrentLiabilities());
if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(4, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(5, liabEqui.nonCurrentLiabilities());
this.setBodyMap(6, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(7, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(8, liabEqui.equityTitle());
this.setBodyMap(9, liabEqui.equity());
this.setBodyMap(10, liabEqui.totalEquity());
this.setBodyMap(11, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(4, liabEqui.equityTitle());
this.setBodyMap(5, liabEqui.equity());
this.setBodyMap(6, liabEqui.totalEquity());
this.setBodyMap(7, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isNonCurrentLiabilityEmpty()) {
this.setBodyMap(1, liabEqui.nonCurrentLiabilitiesTitle());
this.setBodyMap(2, liabEqui.nonCurrentLiabilities());
this.setBodyMap(3, liabEqui.totalNonCurrentLiabilities());
this.setBodyMap(4, this.totalLiabilities());
if (!liabEqui.isEquityEmpty()) {
this.setBodyMap(5, liabEqui.equityTitle());
this.setBodyMap(6, liabEqui.equity());
this.setBodyMap(7, liabEqui.totalEquity());
this.setBodyMap(8, this.totalLiabilitiesEquity());
}
} else if (!liabEqui.isEquityEmpty()) {
}
this.setBodyMap(1, liabEqui.equityTitle());
this.setBodyMap(2, liabEqui.equity());
this.setBodyMap(3, liabEqui.totalEquity());
this.setBodyMap(4, this.totalLiabilitiesEquity());
} else {
bs = false;
}
model1 = new ReportsModelData(getBodyMap(), getTableHeaders());
table.setModel(model1);
TableRowSorter<ReportsModelData> sorter = new TableRowSorter<>(model1);
table.setRowSorter(sorter);
return bs;
}
private List totalAssets() {
}
private List totalLiabilities() {
}
private List totalEquity() {
}
private List totalLiabilitiesEquity() {
}
@Override
public String getTitle(String date) {
return title;
}
@Override
public List<String> getTableHeaders() {
return tableHeaders;
}
@Override
public List<Object> getBodyList() {
return dataBody;
}
@Override
public Map<Integer, List<Object>> getBodyMap() {
return data;
}
@Override
public void setTitle(String title) {
this.title = title;
}
@Override
public void setTableHeader(String header) {
tableHeaders.add(header);
}
@Override
public void setBodyList(String body) {
dataBody.add(body);
}
@Override
public void setBodyMap(Integer index, List<Object> body) {
data.put(index, body);
}
}
How could I have better implemented this class?
2 answers
solution1
4 2017-05-03 07:57:14
You're forcing yourself to use all these nested statements because of the redundant index key that keeps changing position. Using a list instead of a map should solve most of the problem:
private List<List<Object>> data = new ArrayList<>();
public boolean createBalanceSheet(JTable table, String materialDate) {
//...
if (!asset.isAssetsEmpty()) {
data.add(asset.mainAssetTitle());
}
if (!asset.isCurrentAssetsEmpty()) {
data.add(asset.currentAssetTitle());
data.add(asset.currentAssets());
data.add(asset.totalCurrentAssets());
}
if (!asset.isNonCurrentAssetsEmpty()) {
data.add(asset.nonCurrentAssetTitle());
data.add(asset.nonCurrentAssets());
data.add(asset.totalNonCurrentAssets());
data.add(this.totalAssets());
}
// and so on...
}
If you absolutely must return a Map<Integer, List<Object>> , you can easily transform your list to produce the same:
@Override
public Map<Integer, List<Object>> getBodyMap() {
Map<Integer, List<Object>> result = new HashMap<>();
for (int i = 0; i < data.size(); i++) {
result.put(i, data.get(i));
}
return result;
}
solution2
3 ACCPTED 2017-05-03 07:52:18
The typical answer is: look to the Single Responsbility Principle and polymorphism. The other rule that comes into play here: Tell don't ask .
Meaning: your code is asking some other object to provide some internal state information. And based on that information, that code makes decisions. The "more OO" approach is: just tell that other object to do something itself. It knows best about its internal state.
Beyond that; your problem can't be fixed easily. You have to step and look at the "whole" thing. Basically you have some "input data" and a set of "rules" to determine how to build an "output" from that input. A real solution would model these elements (input, output, rules ) and allow you to express the required relationships in a "tabular" form for example.
The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.
Related Question
How to avoid many if-else statements
How to avoid if-else statements in this scenario
How can I avoid so many if statements in copying one object to another?
How to avoid many if-else with many condition
How to avoid many if/else conditions in the method?
How can avoid if else statements and rewrite them into smaller and cleaner code?
How can I avoid using streams and if else statements?
how to avoid multiple if-else statements for vaildation in Java
Mutiple values testing, how to replace many else if statements?
How to avoid multiple if else block so that the code does not smell?
Related Tags