bash script creating vhosts in centos 7

Question

I have the following bash file that creates vhosts in centos 7 HTTP, I am facing the issue in the "ln -s " command.

If I run (sudo sh vhost.sh create anothersite.com my_dir ) I see the "ln -s" output ( /etc/httpd/sites-enabled//etc/httpd/sites-available/anothersite.com.conf), as you can see from the script the variables are the same but in the ln command just the second variable display it.

ln -s /etc/httpd/sites-available/$sitesAvailabledomain /etc/httpd/sites-enabled/$sitesAvailabledomain

#!/bin/bash
### Set Language
TEXTDOMAIN=virtualhost

### Set default parameters
action=$1
domain=$2
rootDir=$3
owner=$(who am i | awk '{print $1}')
email='webmaster@localhost'
sitesEnable='/etc/httpd/sites-enabled/'
sitesAvailable='/etc/httpd/sites-available/'
userDir='/var/www/'
sitesAvailabledomain=$sitesAvailable$domain.conf

### don't modify from here unless you know what you are doing ####

if [ "$(whoami)" != 'root' ]; then
    echo $"You have no permission to run $0 as non-root user. Use sudo"
        exit 1;
fi

if [ "$action" != 'create' ] && [ "$action" != 'delete' ]
    then
        echo $"You need to prompt for action (create or delete) -- Lower-case only"
        exit 1;
fi

while [ "$domain" == "" ]
do
    echo -e $"Please provide domain. e.g.dev,staging"
    read domain
done

if [ "$rootDir" == "" ]; then
    rootDir=${domain//./}
fi

### if root dir starts with '/', don't use /var/www as default starting point
if [[ "$rootDir" =~ ^/ ]]; then
    userDir=''
fi

rootDir=$userDir$rootDir

if [ "$action" == 'create' ]
    then
        ### check if domain already exists
        if [ -e $sitesAvailabledomain ]; then
            echo -e $"This domain already exists.\nPlease Try Another one"
            exit;
        fi

        ### check if directory exists or not
        if ! [ -d $rootDir ]; then
            ### create the directory
            mkdir $rootDir
            ### give permission to root dir
            chmod 755 $rootDir
            ### write test file in the new domain dir
            if ! echo "<?php echo phpinfo(); ?>" > $rootDir/phpinfo.php
            then
                echo $"ERROR: Not able to write in file $rootDir/phpinfo.php. Please check permissions"
                exit;
            else
                echo $"Added content to $rootDir/phpinfo.php"
            fi
        fi

        ### create virtual host rules file
        if ! echo "
        <VirtualHost *:80>
            ServerName $domain
            ServerAlias $domain
            DocumentRoot $rootDir
        </VirtualHost>" > $sitesAvailabledomain
        then
            echo -e $"There is an ERROR creating $domain file"
            exit;
        else
            echo -e $"\nNew Virtual Host Created\n"
        fi


        ### enable website
        ln -s /etc/httpd/sites-available/$sitesAvailabledomain  /etc/httpd/sites-enabled/$sitesAvailabledomain

        ### restart Apache
        /etc/init.d/httpd reload

        ### show the finished message
        echo -e $"Complete! \nYou now have a new Virtual Host \nYour new host is: http://$domain \nAnd its located at $rootDir"
        exit;
    else
        ### check whether domain already exists
        if ! [ -e $sitesAvailabledomain ]; then
            echo -e $"This domain does not exist.\nPlease try another one"
            exit;
        else
            ### Delete domain in /etc/hosts
            newhost=${domain//./\\.}
            sed -i "/$newhost/d" /etc/hosts


            ### restart Apache
            service httpd restart

            ### Delete virtual host rules files
            rm $sitesAvailabledomain
        fi

        ### check if directory exists or not
        if [ -d $rootDir ]; then
            echo -e $"Delete host root directory ? (y/n)"
            read deldir

            if [ "$deldir" == 'y' -o "$deldir" == 'Y' ]; then
                ### Delete the directory
                rm -rf $rootDir
                echo -e $"Directory deleted"
            else
                echo -e $"Host directory conserved"
            fi
        else
            echo -e $"Host directory not found. Ignored"
        fi

        ### show the finished message
        echo -e $"Complete!\nYou just removed Virtual Host $domain"
        exit 0;
fi

Answer 1

It seems that, here you create your variable $sitesAvailabledomain

sitesAvailable='/etc/httpd/sites-available/'
sitesAvailabledomain=$sitesAvailable$domain.conf

and it has value = '/etc/httpd/sites-available/anothersite.com.conf' at this point. Assuming your input for $1 $2 $3 from question.

And here when you use your variable in ln command (which - remember - has value '/etc/httpd/sites-available/anothersite.com.conf')

    ln -s /etc/httpd/sites-available/$sitesAvailabledomain  /etc/httpd/sites-enabled/$sitesAvailabledomain

With extra path pre-pended, so it becomes '/etc/httpd/sites-available//etc/httpd/sites-available/anothersite.com.conf'