java.sql.SQLException: Invalid column index while inserting data

Question

I am trying to insert values into a table, but it always throws "java.sql.SQLException: Invalid column index". I had verified the column indexes as per my knowledge. Below is what I tried.

stmt = con.prepareStatement("insert into test_table(ASSESMENT_YEAR,ASSESMENT_MON,CODE,KRA_CODE,BASE_VALUE,ACTUAL_VALUE,USERNAME,CHANGE_DATE)"
                + "values (?,?,?,?,?,?,?,SYSDATE)");

        stmt.setInt(1, Calendar.getInstance().get(Calendar.YEAR));
        stmt.setInt(2, Calendar.getInstance().get(Calendar.MONTH));
        stmt.setString(3, getcode(dm.getStr1(), dm.getStr2())); 
        stmt.setString(4, dm.getStr4());
        stmt.setInt(5, dm.getNum1());
        stmt.setInt(6, dm.getNum2());
        stmt.setString(7, "admin");

The above is throwing error in the 4th stmt. But if I hardcode the values as below, data gets properly inserted.

        stmt.setInt(1, 2018);
        stmt.setInt(2, 12);
        stmt.setString(3, "1111"); 
        stmt.setString(4, "0000");
        stmt.setInt(5, 12);
        stmt.setInt(6, 1);
        stmt.setString(7, "admin");

Any help would be appriciated!!

Edit: Below is the stacktrace

java.sql.SQLException: Invalid column index
    at oracle.jdbc.driver.OraclePreparedStatement.setStringInternal(OraclePreparedStatement.java:5386)
    at oracle.jdbc.driver.OraclePreparedStatement.setString(OraclePreparedStatement.java:5374)
    at oracle.jdbc.driver.OraclePreparedStatementWrapper.setString(OraclePreparedStatementWrapper.java:282)
    at com.dao.KRADataDao.addData(KRADataDao.java:59)
    at com.service.Controller.service(Controller.java:56)
    at com.service.Dispatcher.service(Dispatcher.java:25)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:475)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
    at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:625)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
    at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:498)
    at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
    at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:796)
    at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1372)
    at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
    at java.lang.Thread.run(Unknown Source)

The Below segment is also not working :

        stmt.setInt(1, Calendar.getInstance().get(Calendar.YEAR));
        stmt.setInt(2, Calendar.getInstance().get(Calendar.MONTH));
        stmt.setString(3, getcode(dm.getStr1(), dm.getStr2())); 
        stmt.setString(4, "0000");
        stmt.setInt(5, dm.getNum1());
        stmt.setInt(6, dm.getNum2());
        stmt.setString(7, "admin");

Answer 1

It could be a reuse of stmt . Use the try-with-resources syntax for a local instance, automatically closed, even on exception:

try (PreparedStatement stmt = con.prepareStatement("insert into test_table"
            + "(ASSESMENT_YEAR,ASSESMENT_MON,CODE,KRA_CODE,BASE_VALUE,ACTUAL_VALUE,"
            + "USERNAME,CHANGE_DATE)"
            + "values (?,?,?,?,?,?,?,SYSDATE)")) {
    stmt.setInt(1, Calendar.getInstance().get(Calendar.YEAR));
    stmt.setInt(2, Calendar.getInstance().get(Calendar.MONTH));
    stmt.setString(3, getcode(dm.getStr1(), dm.getStr2())); 
    stmt.setString(4, dm.getStr4());
    stmt.setInt(5, dm.getNum1());
    stmt.setInt(6, dm.getNum2());
    stmt.setString(7, "admin");

    stmt.executeUpdate();
}

My guess is that in getcode the reuse of stmt happens.

In general always use local variables, try-with-resources. Some PreparedStatements might benefit from a longer scope, but with fixed SQL, and the name then should not be stmt .

Answer 2

If the column does not exist, or you must enter the stmt.executeUpdate(); statement.

Answer 3

I don't know what database system you are using. So please verify that CODE is not a reserved word / keyword.

In that case please rename the third column and try again.