comparing strings

Question

Considering this piece of code

char *pass="test";
int keyPressed;
char *password=(char *)malloc(PASS_LENGTH*sizeof(char));
int index=0;
printf("Enter the password please\n");
do
{
    keyPressed=getch();
    password[index++]=keyPressed;
}
while(keyPressed!=13);
int result=strcmp(pass,password);

I think you understand what i want to do :)
I read in *password "test" but result is not 0, some explanation would be good:)

Answer 1

因为我认为这是作业...尝试在按下Enter后写出字符串，看看你是否能看到差异。

Answer 2

You have to remove the last character and "close" the string: put

password[index - 1] = '\0' 

after the do-while.

Answer 3

akappa's suggestion will fix the strcmp problem you're seeing.

Also note you're mallocing a finite amount of memory but when writing this memory you don't check against the size of the allocated block. The code as written will allow writing passed the end of "password".

Answer 4

Looks like it would be "test\\n" because you already added keyPressed. Thereby also overflowing the password variable.

Answer 5

You should malloc PASS_LENGTH+1 and set password[index] = 0 at before the last line of code. as strcmp and other C str routines work with ASCIIZ strings

Answer 6

回车包含在password的末尾。