GenericFilterBean response error doesn't work for all endpoints

Question

I have implemented a GenericFilterBean to filter jwt tokens :

    public class AuthFilter extends GenericFilterBean {

    @Override
    public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, FilterChain filterChain) throws IOException, ServletException {
        HttpServletRequest httpRequest = (HttpServletRequest) servletRequest;
        HttpServletResponse httpResponse = (HttpServletResponse) servletResponse;

        String authHeader = httpRequest.getHeader("Authorization");
        if (authHeader != null){
            String[] authHeaderArr = authHeader.split("Bearer");
            if(authHeaderArr.length > 1 && authHeaderArr[1] != null) {
                String token = authHeaderArr[1];
                try {
                    Claims claims = Jwts.parserBuilder().setSigningKey(Constants.API_SECRET_KEY).build()
                            .parseClaimsJws(token).getBody();
                    httpRequest.setAttribute("userId", Long.parseLong(claims.get("userId").toString()));
                }catch (Exception e) {
                    httpResponse.sendError(HttpStatus.FORBIDDEN.value(), "invalid/expired token");
                }
            } else {
                httpResponse.sendError(HttpStatus.FORBIDDEN.value(),
                        "Authorization token must be Bearer[token]");
            }
        } else {
            httpResponse.sendError(HttpStatus.FORBIDDEN.value(),
                    "Authorization token must be provided");
        }
        filterChain.doFilter(servletRequest, servletResponse);
    }
}

The filter seems to work fine and when adding url patterns they seem to be catched successfully. The issue is that the response error if the jwt is incorrect only works on one endpoint.

The working endpoint :

The other endpoints :

My filter looks like that :

public class WeyApplication {

    public static void main(String[] args) {
        SpringApplication.run(WeyApplication.class, args);
    }

    @Bean
    public FilterRegistrationBean<AuthFilter> filterRegistrationBean () {
        FilterRegistrationBean<AuthFilter> registrationBean = new FilterRegistrationBean<>();
        registrationBean.setFilter(new AuthFilter());
        registrationBean.addUrlPatterns(
                "/api/en/fleet/*",
                "/api/en/users/*",
                "/api/en/ride/*",
                "/api/en/ride-request/*"
        );
        return registrationBean;
    }
}

I don't think the problem is with the url pattern since I debugged and all the endpoints added to the registrationBean does go through the doFilter method.

Answer 1

Wasn't aware of that but I found out while testing that Exceptions overide the response. Adding a try catch or a Error handler fixes it.

    @GetMapping("/me/account")
    public ResponseEntity<PrivateUser> getUserDetails(HttpServletRequest request,
                                                      @PathVariable String lang) {
        Long userId = (Long) request.getAttribute("userId");
        try {
            User user = userService.getUserDetails(userId, lang);
            return new ResponseEntity<>(user.getPrivateData(), HttpStatus.OK);
        } catch (Exception e) {
            return new ResponseEntity<>(HttpStatus.UNAUTHORIZED);
        }
    }