Microsoft OLE DB Provider for SQL Server error '80040e14'

Question

Stored procedure, and using ADO to connect, i'm having problems with the quotes however..

    x = "text'"

    If instr(x,"'") then x=replace(x,"'","''")

    'x = "text''" at this point

    Set Rs = Server.Createobject("adodb.recordset")
    Rs.Open "Select_SP @name='" & x & "'"

I thought i was doing this right.. But I guess not, because i'm getting this error:

    Microsoft OLE DB Provider for SQL Server  error '80040e14' 
    SELECT ID from Table where Name='text''

Shouldn't it be

Name = 'text'''

Why isn't SQL recognizing the double quotes using ADO?

The Select_SP Uses something like this:

     SET @sql = 'SELECT ID from Table where Name='''+@name+''''
     Exec(@sql)

Do I have this SP written correctly?

Answer 1

The short answer is, don't call procedures the way you're doing it. Use a Command instead. This is from memory, since I don't have a Windows system in front of me at the moment, but it should work:

Dim cmd
Set cmd = Server.CreateObject("ADODB.Command")
Set Cmd.ActiveConnection = myConnectionVariableHere
cmd.CommandType = adCmdStoredProc
cmd.CommandText = "Select_SP"

'Note: if the above two lines don't work, replace them with the following
'cmd.CommandType = adCmdText
'cmd.CommandText = "Select_CP @name=?"

cmd.Parameters.Append cmd.CreateParameter("name", adVarChar, adParamInput, len(x), x)
Rs.Open cmd

Now, all that said, I can't tell you why your procedure is giving that particular output since you're not showing us the code for it. But I'm fairly certain ADO isn't going to convert a pair of single quotes into a double quote - not sure why you'd expect it to.

Edit after seeing the OP's edit. Don't execute SQL that way unless you absolutely have to. You will only give yourself grief. I don't know what database you're using and that procedure syntax doesn't look familiar, but in Oracle you could write something like:

PROCEDURE sql_test(MyName IN VARCHAR2, MyCursor OUT SYS_REFCURSOR) IS
BEGIN
  OPEN MyCursor FOR SELECT id FROM some_table WHERE name = MyName;
END;