checked iterator

Question

I am trying to test the example of "checked iterator" from Stroustrup's C++ book. The code has a run time error: "list iterators incompatible".

The error is trigger by " if( c->end() == p ) " of function " valid() ". What does this error mean? I guess both c->end() and p should be of type list<int>::iterator .

In addition, I don't understand why "operator" was implemented in that way. BTW, I am using VS2008.

struct out_of_bounds{
    out_of_bounds() {}
};

template<class Cont, class Iter = typename Cont::iterator>
class Checked_iter : public iterator_traits<Iter> // deriving from iterator_traits
{
    Iter curr;   // iterator for current position
    Cont* c;    // pointer to current container
    // ...
public:

    void valid(Iter p){
        if ( c->end() == p )
            return;
        for (Iter pp = c->begin(); pp != c->end(); ++pp ){
            if ( pp == p )
                return;
        }
        throw out_of_bounds();
    }

    friend bool operator==(const Checked_iter& i, const Checked_iter& j){
        return i.c == j.c && i.curr == j.curr;
    }

    // no default initializer
    // use default copy constructor and copy assignment
    Checked_iter(Cont x, Iter p) : c(&x), curr(p) { valid(p); }

    reference operator*(){
        if ( curr == c->end() ) throw out_of_bounds();
        return *curr;
    }

    pointer operator->(){
        return &*curr; // checked by *
    }

    Checked_iter operator+(difference_type d){ // for random-access iterator only
        if ( c->end() - curr <= d  )
            throw out_of_bounds();
        return Checked_iter(c, curr+d);
    }

    reference operator[](difference_type d){ // for random-access iterator only
        if ( c->end() - curr <= d  ) throw out_of_bounds();
        return c[d]; 
    }

    Checked_iter& operator++(){ // prefix ++
        if ( curr == c->end() ) throw out_of_bounds();
        ++curr;
        return *this;
    }

    Checked_iter& operator++(int) { // postfix ++
        Checked_iter temp = *this;
        ++*this; // checked by prefix ++
        return temp;
    }

    Checked_iter& operator--() { // prefix --
        if ( curr == c->begin() ) throw out_of_bounds();
        --curr;
        return *this;
    }

    Checked_iter& operator--(int) { // postfix --
        Checked_iter temp = *this;
        --*this;  // check by prefix
        return temp;
    }

    difference_type index() { return curr-c.begin(); } // random-access only
    Iter unchecked(){ return curr; }
};

void f2(list<int>& ls){

    int count = 0;
    try{
        Checked_iter< list<int> > p(ls, ls.begin() );
        while(true){
            ++p;
            ++count;
            //cout << "element: " << *p << "   count: " << count << endl;
        }
    }
    catch(out_of_bounds){
        cout << "overrun after " << count << " tries \n";
    }

}

void test9(){
    int a[] = {0,1,2,3,4,5,6,7,8,9};
    list<int> l(a, a+sizeof(a)/sizeof(int));
    show(l);
    f2(l);
}

Answer 1

The constructor for Checked_iter should take Cont&, not Cont. You are storing a pointer to a temporary copy.