stackoom
  简体   繁体   中英

Pass a string parameter in an onclick function

 原文  2012-03-10 02:05:49  2   27    javascript/ html

Question

I would like to pass a parameter (ie a string) to an Onclick function.

For the moment, I do this:

'<input type="button" onClick="gotoNode(' + result.name + ')" />'

with result.name for example equal to string "Add".

When I click on this button, I have an error that says that "Add is not defined" . Since this function call works perfectly with a numeric parameter, I assume that it has something to do with the symbols "" in the string.

How can I fix this problem?

27 answers

solution1
 430 ACCPTED  2012-03-10 02:41:22

It looks like you're building DOM elements from strings. You just need to add some quotes around result.name:

'<input type="button" onClick="gotoNode(\'' + result.name + '\')" />'

You should really be doing this with proper DOM methods though.

var inputElement = document.createElement('input');
inputElement.type = "button"
inputElement.addEventListener('click', function(){
    gotoNode(result.name);
});

​document.body.appendChild(inputElement);​

Just be aware that if this is a loop or something, result will change before the event fires and you'd need to create an additional scope bubble to shadow the changing variable.

solution2
 50  2016-07-28 09:38:35

A couple of concerns for me with respect to using string escape in onClick and as the number of arguments grow, it will become cumbersome to maintain.

The following approach will have a one hop - On click - take the control to a handler method and handler method, based on the event object, can deduct the click event and corresponding object.

It also provides a cleaner way to add more arguments and have more flexibility.

<button type="button"
        className="btn btn-default"
        onClick="invoke"
        name='gotoNode'
        data-arg1='1234'>GotoNode</button>

In the JavaScript layer:

  invoke = (event) => {
    let nameOfFunction = this[event.target.name];
    let arg1 = event.target.getAttribute('data-arg1');
    // We can add more arguments as needed...
    window[nameOfFunction](arg1)
    // Hope the function is in the window.
    // Else the respective object need to be used
    })
  }

The advantage here is that we can have as many arguments (in above example, data-arg1, data-arg2, etc.) as needed.

solution3
 30  2012-03-10 02:12:36

I suggest not even using HTML onclick handlers, and use something more common such as document.getElementById .

HTML: 

<input type="button" id="nodeGoto" />

JavaScript: 

document.getElementById("nodeGoto").addEventListener("click", function() {
    gotoNode(result.name);
}, false);

solution4
 23  2015-10-30 15:57:21

This is a nice and neat way to send a value or object.

<!DOCTYPE html>
<html>
    <body>
        <h1  onclick="test('wow',this)">Click on this text!</h1>
        <script>
            var test = function(value,object) {
                object.innerHTML= value;
            };
        </script>
    </body>
</html>

solution5
 21  2012-03-10 02:42:34

I am guessing, you are creating a button using JavaScript itself. So, the error in your code is that, it will render in this form

<input type="button" onClick="gotoNode(add)" />'

At this current state, add will be considered as an identifier like variables or function calls. You should escape the value like this

'<input type="button" onClick="gotoNode(\'' + result.name + '\')" />'

solution6
 11  2014-11-26 23:07:10

Try this...

HTML: 

<button id="a1" type="button" onclick="return a1_onclick('a1')">a1</button>

JavaScript: 

<script language="javascript" type="text/javascript">
    function a1_onclick(id) {
        document.getElementById(id).style.backgroundColor = "#F00";
    }
</script>

Note: be sure of sending arguments between ' ' signs like ('a1') in HTML code

solution7
 10  2018-06-27 10:38:40

If your button is generated dynamically:

You can pass string parameters to JavaScript functions like the below code:

I passed three parameters where the third one is a string parameter.

var btn ="<input type='button' onclick='RoomIsReadyFunc("+ID+","+RefId+",\""+YourString+"\");'  value='Room is Ready' />";

// Your JavaScript function

function RoomIsReadyFunc(ID, RefId, YourString)
{
  alert(ID);
  alert(RefId);
  alert(YourString);
}

solution8
 7  2016-05-01 12:58:39

Also you can use the grave accent symbol ( ` ) in a string

Try:

`<input type="button" onClick="gotoNode('${result.name}')" />`

For more information, visit MDN and Stack Overflow .

By Chrome, Edge, Firefox (Gecko), Opera , Safari support, but it does not support Internet Explorer.

solution9
 7  2012-03-10 02:07:49

If the requirement is to reference the global object (JavaScript) in your HTML code, you can try this. [Don't use any quotes (' or ") around the variable]

Fiddle reference.

JavaScript: 

var result = {name: 'hello'};
function gotoNode(name) {
    alert(name);
}

HTML: 

<input value="Hello" type="button" onClick="gotoNode(result.name)" />​

solution10
 5  2016-11-07 05:41:03

Multiple parameters:

bounds.extend(marker.position);
bindInfoWindow(marker, map, infowindow,
    '<b>' + response[i].driver_name + '</b><br>' +
    '<b>' + moment(response[i].updated_at).fromNow() + '</b>
     <button onclick="myFunction(\'' + response[i].id + '\',\'' + driversList + '\')">Click me</button>'
);

solution11
 2  2017-08-21 19:03:56

要传递多个参数，您可以通过将字符串与ASCII值连接起来来强制转换字符串，例如，对于单引号，我们可以使用' 

var str= "&#39;"+ str+ "&#39;";

solution12
 1  2015-02-24 07:04:04

You can pass a reference or string value. Just put the function inside the double commas "" as per the below snapshot:

在此处输入图像描述

solution13
 1  2018-07-05 05:07:16

If to use for generation of a set of buttons with different parameters of handlers.

JavaScript Closures 

let some_button = document.createElement( "button" );
some_button.type = "button";

some_button.onclick = doWithParam( some_param );

function doWithParam( param ){
    return function(){
        alert( param ); // <-- Your code here
    }
}

If we do:

some_button.onclick = foo( some_param );
function foo( param ){
    alert( param );
}

then function foo starts after every updating page.

If we do:

for( let i = 0; i < 10; ++i ){
    var inputElement = document.createElement('input');
    inputElement.type = "button"
    inputElement.addEventListener('click', function(){
        gotoNode(result.name);
    });

 ​   document.body.appendChild(inputElement);​
}

then for all buttons created in the loop, the last value of the parameter is "result.name".

solution14
 1  2018-07-27 05:15:41

Here is a jQuery solution that I'm using.

jQuery 

$("#slideshow button").click(function(){
    var val = $(this).val();
    console.log(val);
});

HTML 

<div id="slideshow">
    <img src="image1.jpg">
    <button class="left" value="back">&#10094;</button>
    <button class="right" value="next">&#10095;</button>
</div>

solution15
 1  2020-06-30 04:53:28

If you need to pass a variable along with the 'this' keyword, the below code works:

var status = 'Active';
var anchorHTML = '<a href ="#" onClick = "DisplayActiveStatus(this,\'' + status + '\')">' + data+ '</a>';

solution16
 1  2021-01-06 12:10:38

<!----  script ---->
<script>
function myFunction(x) {
  document.getElementById("demo").style.backgroundColor = x; 
}
</script>

<!---- source ---->
<p id="demo" style="width:20px;height:20px;border:1px solid #ccc"></p>

<!----  buttons & function call ----> 
<a  onClick="myFunction('red')" />RED</a> 
<a  onClick="myFunction('blue')" />BLUE</a> 
<a  onClick="myFunction('black')" />BLACK</a>

solution17
 1  2022-01-07 10:17:48

This is work for me:

$(element).attr("onClick", 'functionName(' + "\"" + Object.attribute + "\"" + ')');

Just add \ slash in ()

※Multiple parameters example 

"functionName(" + "'" + parameter1 + "','" + parameter2 + "','" + parameter3 + "','" + parameter4 + "','" + parameter5 + "','" + parameter6 + "')"

solution18
 0  2016-12-06 04:58:17

For passing multiple parameters you can cast the string by concatenating it with the ASCII value. Like, for single quotes we can use &#39; : 

var str = "&#39;" + str + "&#39;";

The same parameter you can pass to the onclick() event. In most of the cases it works with every browser.

solution19
 0  2017-05-31 13:16:03

<style type="text/css">
    #userprofile{
        display: inline-block;
        padding: 15px 25px;
        font-size: 24px;
        cursor: pointer;
        text-align: center;
        text-decoration: none;
        outline: none;
        color: #FFF;
        background-color: #4CAF50; // #C32836
        border: none;
        border-radius: 15px;
        box-shadow: 0 9px #999;
        width: 200px;
        margin-bottom: 15px;
    }
    #userprofile:hover {
        background-color: #3E8E41
    }

    #userprofile:active {
        background-color: #3E8E41;
        box-shadow: 0 5px #666;
        transform: translateY(4px);
    }

    #array {
        border-radius: 15px 50px;
        background: #4A21AD;
        padding: 20px;
        width: 200px;
        height: 900px;
        overflow-y: auto;
    }
</style>

if (data[i].socketid != "") {
    $("#array").append("<button type='button' id='userprofile' class='green_button' name=" + data[i]._id + " onClick='chatopen(name)'>" + data[i].username + "</button></br>");
}
else {
    console.log('null socketid  >>', $("#userprofile").css('background-color'));
    //$("#userprofile").css('background-color', '#C32836 ! important');

    $("#array").append("<button type='button' id='userprofile' class='red_button' name=" + data[i]._id + " onClick='chatopen(name)'>" + data[i].username+"</button></br>");
    $(".red_button").css('background-color','#C32836');
}

solution20
 0  2018-11-22 05:39:05

If you are using ASP.NET you can use JavaScript:

HTML 

<input type='button' value='test' onclick='javascript: EditSelectedOptionName(x,y)' />"

JavaScript 

function EditSelectedOptionName(id, name) {
    console.log(id);
    console.log(name);
}

solution21
 0  2019-09-04 12:35:17

If you are adding buttons or link dynamically and facing the issue then this may be help. I solved it by this way:

var link= $(contentData1[i]).find("td:first font b a").attr("href",'javascript:onClick=openWin(\'' + tdText + '\')');

I am new to HTML, jQuery and JavaScript. So maybe my code will not be optimized or syntax, but it was working for me.

solution22
 0  2020-04-08 14:04:27

在Razor中，您可以动态传递参数：

<a href='javascript:void(0);' onclick='showtotextbox(@Model.UnitNameVMs[i].UnitNameID, "@Model.UnitNameVMs[i].FarName","@Model.UnitNameVMs[i].EngName","@Model.UnitNameVMs[i].Symbol" );'>@Model.UnitNameVMs[i].UnitNameID</a>

solution23
 0  2020-05-22 06:40:32

You can use this:

'<input id="test" type="button" value="' + result.name + '" />'

$(document).on('click', "#test", function () {
    alert($(this).val());
});

It worked for me.

solution24
 0  2020-09-01 08:46:10

let task = {....}

<button onclick="myFunction('${task}')">Continue task</button></li>

solution25
 0  2021-02-16 07:39:25

Not escaping double quotes is the cause of OP's problem. A readable approach to escape double quotes is using backticks ( MDN ). Here is a sample solution:

my_btn.setAttribute('onclick', `my_func("${onclick_var1}", "${onclick_var2}")`);

solution26
 -1  2018-01-11 13:59:08

您可以在按钮 onclick 方法中使用此代码：

<button class="btn btn-danger" onclick="cancelEmployee(\''+cancelButtonID+'\')" > Cancel </button>

solution27
 -1  2018-05-11 08:29:41

The following works for me very well,

<html>
<head>
    <title>HTML Form</title>
</head>
<body>
    <form>
        <input type="button" value="ON" onclick="msg('ON')">
        <input type="button" value="OFF" onclick="msg('OFF')">
    </form>
    <script>
        function msg(x){
            alert(x);
        }
    </script>
</body>
</html>

solution28
 -1  2022-06-01 13:55:19

<button style="background-color: gray;color:white;" onclick="displayAlert('the message')">alert</button>
<script>
    function displayAlert(msg){
        alert(msg);
    }

</script>

暂无
暂无

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

Related Question Pass a string as a parameter to a function onclick event jquery how to pass string parameter in onclick function Pass a Parameter to an onClick Function How to pass string parameter into function in button onclick event pass string parameter in an onclick call How to pass parameter to an onclick function Pass parameter to function onclick jQuery pass multiple parameter in an onclick function How to pass a parameter in an onclick function? How to pass string parameter through onclick
Related Tags
 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM