How can I simplify below code? How can I get rid of the if statements? I want to highlight some lines in ajax response. Right now I have two strings to compare = two ifs. This number will increase so I am thinking of doing this some other way - using an array of the strings that needs to be highlighted in case the string is part of data_array element.
I prefer a solution in javascript only but jQuery is ok too.
data_array=data.split('<BR>');
for(var i=0, len=data_array.length; i < len; i++){
if (data_array[i].indexOf('Conflict discovered') >= 0){
data_array[i]="<span class='red'>"+data_array[i]+"</span>";
}
if (data_array[i].indexOf('Syntax error') >= 0){
data_array[i]="<span class='red'>"+data_array[i]+"</span>";
}
}
data=data_array.join('<BR>');
Why not add another for
loop?
data_array=data.split('<BR>');
var stringsToFind = ['Conflict discovered', 'Syntax error'];
for (var i = 0; i < data_array.length; i++) {
for (var j = 0; j < stringsToFind.length; j++) {
var currItem = data_array[i];
if (currItem.indexOf(stringsToFind[j]) >= 0) {
data_array[i]='<span class="red">' + currItem + '</span>';
}
}
}
data = data_array.join('<BR>');
jQuery (note, may be slower, and I haven't tested this yet)
data_array=data.split('<BR>');
var stringsToFind = ['Conflict discovered', 'Syntax error'];
$.each(data_array, function(i, item) {
$.each(stringsToFind, function(j, s) {
if (item.indexOf(s) >= 0) {
data_array[i]='<span class="red">' + item + '</span>';
}
}
});
data = data_array.join('<BR>');
Add more elements to the array as desired :)
data.replace( /<br>/ig, '\n' ).replace(
new RegExp( '^(.*(?:' + [
'Conflict discovered'
, 'Syntax error'
].join( '|' ) + ').*)$', 'gm' )
, '<span class="red">$1</span>' ).replace( /\n/g, '<br>' );
explanation:
<br>
tags with line breaks ^(.*(?:Conflict discovered|Syntax error).*)$
<span class="red">
... </span>
<br>
tags var data_array = data.split('<BR>');
var errMsgs = ['Conflict discovered', 'Syntax error'];
data_array = data_array.map(function(data_rec) {
var isAnError = errMsgs.some(function (errMsg) {
return data_rec.indexOf(errMsg) >= 0;
});
if (isAnError) {
return "<span class='red'>" + data_rec + '</span>';
} else {
return data_rec;
}
});
var highlightWords = ['Conflict discovered', 'Syntax error', 'Simply cool'];
for(i=0; i<highlightWords.length; i++){
var regex = new RegExp(highlightWords[i],'ig');
data= data.replace( regex, '<span class="red">'+ highlightWords[i] +'</span>');
}
$('div').html( data );
var words = ['Conflict discovered', 'Syntax error', 'Strange'];
var data_array=data.split('<BR>');
for(n=0;n<words.length;n++){
for(i=0; i<data_array.length; i++){
if (data_array[i].indexOf( words[n] ) >= 0){
data_array[i]="<span class='red'>"+data_array[i]+"</span>";
}
}
data = data_array.join('<BR>');
}
$('div').html( data );
data_array=data.split('<BR>');
for(var i=0, len=data_array.length; i < len; i++){
var dai = data_array[i];
if (dai.indexOf('Conflict discovered') >= 0 || dai.indexOf('Syntax error') >= 0){
data_array[i] = "<span class='red'>"+dai+"</span>";
}
}
data=data_array.join('<BR>');
The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.