Java method for type safe return generic subclass

Question

I'm using the following code to get the first matching element with the given class (Dog, Cat) from a list of abstract type (Animal). Is there another type safe way to do it?

// get the first matching animal from a list
public <T extends Animal>T get(Class<T> type) {
    // get the animals somehow
    List<Animal> animals = getList();
    for(Animal animal : animals) {
        if(type.isInstance(animal)) {
            // this casting is safe
            return (T)animal;
        }
    }
    // if not found
    return null;
}

// both Cat and Dog extends Animal
public void test() {
    Dog dog = get(Dog.class); // ok
    Cat cat = get(Dog.class); // ok, expected compiler error
}

(Cat and Dog extends Animal)

Answer 1

The code looks correct. This line:

Cat cat = get(Dog.class);

Indeed should not compile.

I would make sure you're not using rawtypes anywhere in your code, as often this will "opt out" of generics for seemingly unrelated code.

Answer 2

I get compiler error with your code:

public void test() {
    Dog dog = get(Dog.class); // ok
    Cat cat = get(Dog.class); // compiler error
}

and I can see only one case when it may compile:

class Dog extends Cat {
}

Answer 3

I would change one thing in your code. Instead of

return (T)animal;

I would use

return type.cast(animal);

The latter will not generate unchecked cast warning.