Android: fill spinner with items in text file

Question

I want fill spinner with items in text file on my hosting. The text file content separate with "\\n" character:

Afghanistan
Albania
Algeria
Andorra
Angola

I write this code but I've this error :

03-10 12:32:07.716: E/AndroidRuntime(7670): 
FATAL EXCEPTION: Thread-69056
03-10 12:32:07.716: 

E/AndroidRuntime(7670): 
java.lang.ArrayIndexOutOfBoundsException: 
length=91; index=91

                    bo.write(buffer);
                    String s = bo.toString();

                    final Vector<String> str = new Vector<String>();
                    String[] line = s.split("\n");
                    int index = 0;
                    while (line[index] != null) {
                        str.add(line[index]);
                        index++;
                    }

Answer 1

you need to change the condition.. with this:

while (line[index] != null) {
   str.add(line[index]);
   index++;
}

if say the size of line is 10, index++ will make it 11. thus line[11] will not be null but rather throw an ArrayIndexOutOfBoundsException .

change the condition to :

for(int i=0;i<line.length;i++) {
    if(line[i] != null) {
       str.add(line[index]);
    }
}

Answer 2

You need to be check by the length of your String array in for loop

for(int i=0;i<line.length;i++) {
if(line[i] != null) {
   str.add(line[index]);
}
}

Answer 3

Change code to:

bo.write(buffer);
String s = bo.toString();
final Vector<String> str = new Vector<String>();
String[] line = s.split("\n");
int index = 0;
while (index < line.length) {
str.add(line[index]);
index++;
}

You are getting java.lang.ArrayIndexOutOfBoundsException because you are not doing bound checking for line array.

Answer 4

It should be:

int index = 0, length = line.length;
while (index < length) {
   str.add(line[index++]);
}