Convert foreach to Parallel.ForEach

Question

I need convert foreach to Parallel.foreach , anyone can help me ?

    foreach (DataRow row2 in DT.Rows)
    {
       try 
       {
           bool check = (urlcheck(dataGridView.Rows[i].Cells[2].Value.ToString()));
           if (check == true)
              ExecuteQuery("");
           else
              ExecuteQuery("");
       }
       catch{ }
       i++;
     }

Answer 1

I would use an overload of the Parallel.ForEach so your i parameter is provided by the foreach method:

Parallel.ForEach(DT.Rows.OfType<System.Data.DataRow>(), (DataRow row2, ParallelLoopState loopState, long i) =>
{
    try {
        bool check = (urlcheck(dataGridView.Rows[(int)i].Cells[2].Value.ToString()));
        if (check == true)
            ExecuteQuery("");
        else
            ExecuteQuery("");
    }
    catch{ }
});

For the OfType<> method you need to add using System.Linq to your using statements.

Now the index ( i ) is automaticly assigned by the method call so you don't have to worry about thread safety of i .

Answer 2

Parallel.ForEach(DT.Rows, row2 => {
    try
    {
        bool check = (urlcheck(dataGridView.Rows[i].Cells[2].Value.ToString()));
        if (check == true)
            ExecuteQuery("");
        else
            ExecuteQuery("");
    }
    catch { }
    i = i++; 
});

Keep in mind: i = i++; outside thread could be dangroous if used in wrong way. (btw: strange assigment)

Answer 3

Parallel.ForEach(DT.Rows, Row =>
{
  try
  {
    bool check = (urlcheck(dataGridView.Rows[i].Cells[2].Value.ToString()));
    if (check == true)
        ExecuteQuery("");
    else
        ExecuteQuery("");
  }
  catch() {}
  i = i++;
});