简体   繁体   中英

C++ array based stack implementation throwing errors

I'm kinda new to C++, so this must be something trivial. I've implemented a stack using an array but can't seem to call from main. Here's my main( ).

#include <iostream>
#include <cstdlib>
#include "stack.cpp"

int main(){

  myStack = new Stack(10);
  return 0;
}

Here's my .hpp

#include <string>

class Stack {

public:
      Stack(int capacity);

      void push(int value);

      int peek();
      void pop();
      bool isEmpty();

      ~Stack() {
            delete[] storage;
      }

private:
        int top;
        int capacity;
        int *storage;
};

And here's my .cpp

#include "stack.hpp"


Stack::Stack(int capacity) {
      if (capacity <= 0)
            throw std::string("Stack's capacity must be positive");
      storage = new int[capacity];
      this->capacity = capacity;
      top = -1;
}

void Stack::push(int value) {
      if (top == capacity)
            throw std::string("Stack's underlying storage is overflow");
      top++;
      storage[top] = value;
}

int Stack::peek() {
      if (top == -1)
            throw std::string("Stack is empty");
      return storage[top];
}

void Stack::pop() {
      if (top == -1)
            throw std::string("Stack is empty");
      top--;
}

bool Stack::isEmpty() {
      return (top == -1);
}

This is the error message.

client.cpp: In function ‘int main()’:
client.cpp:7:3: error: ‘myStack’ was not declared in this scope
   myStack = new Stack(10);
   ^

Wonder what am I missing.

Stack* myStack = new Stack(10);
...
delete myStack;

Alternatively declare myStack on the stack

Stack myStack(10);

Also look into std::unqiue_ptr so you don't have to write delete myStack.

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM