Removing spaces from a string in C Memory fault

Question

I'm writing a simple code for removing spaces from a string in C however I get the following message after compiling: EXC_BAD_ACCESS (code=2, adresss=....). It's coming from the line '*temp = *str' however I don't understand why? How can I fix it?

void removeSpaces(char * str)
{
  char * temp = str;

  while (*str != '\0') {
    if (*str != ' ') {
      *temp = *str;
      temp++;
     }
    str++;
  }
  *temp = '\0';
}

Answer 1

The function works fine when passed a string declared like this

char s[] = "Hallo  World!";

but if you declared the string like this, as a pointer to string literal

char *s = "Hallo  World!";

you are not supposed to modify the string.

Answer 2

It seems that you are passing an string literal. temp and str pointing to same string literal. With statement *temp = *str; you are modifying the that literal which should not be modified.

To fix the problem allocate memory for temp

char *temp = malloc(strlen(str) + 1);