“Insert Into Select” writing to table but contains sub-query reading from same table

Question

I am adding records into my table "SampleTestLimits" using an "Insert Into Select", but which also has a sub-query reading from the same table to perform a count for me.

I don't think the sub-query is seeing the earlier records added by my "Insert Into Select". It's the same for Oracle and SQL Server. The code for SQL Server is shown below (my sub-query begins with "SELECT COALESCE...").

I have another stored procedure which does work in a similar situation.

Would appreciate it if anybody could tell if what I'm doing is a no no.

ALTER PROCEDURE [dbo].[CreateSampleTestLimits]
@SampleCode as NVARCHAR(80),
@TestPosition as smallint,
@TestCode NVARCHAR(20),
@TestVersion smallint,
@EnterDate as integer,
@EnterTime as smallint,
@EnterUser as NVARCHAR(50)
AS
BEGIN
INSERT INTO SampleTestLimits
([AuditNumber]
,[LimitNumber]
,[ComponentRow]
,[ComponentColumn]
,[ComponentName]
,[TestPosition]
,[SampleCode]
,[AuditFlag]
,[LimitSource]
,[LimitType]
,[UpperLimitEntered]
,[UpperLimitValue]
,[LowerLimitEntered]
,[LowerLimitValue]
,[LimitTextColour]
,[LimitPattern]
,[LimitForeColour]
,[LimitBackColour]
,[CreatedDate]
,[CreatedTime]
,[CreatedUser]
,[LimitText]
,[FilterName]
,[deleted]
,IsRuleBased)
SELECT 1 --starting auditnumber
,(SELECT COALESCE(MAX(LimitNumber), 0) + 1 AS NextLimitNumber FROM SampleTestLimits WHERE SampleCode=@SampleCode AND TestPosition=@TestPosition AND ComponentRow=1 AND ComponentColumn=1 AND AuditFlag=0) -- TFS bug# 3952: Calculate next limit number.
,ComponentRow
,ComponentColumn
,(select ComponentName from TestComponents TC where TC.TestCode=@TestCode and TC.ComponentColumn=TestLimits.ComponentColumn and TC.ComponentRow = TestLimits.ComponentRow and TC.AuditNumber=TestLimits.AuditNumber)
,@TestPosition
,@SampleCode
,0 --auditflag
,1 --limitsource = test
,[LimitType]
,[UpperLimitEntered]
,[UpperLimitValue]
,[LowerLimitEntered]
,[LowerLimitValue]
,[LimitTextColour]
,[LimitPattern]
,[LimitForeColour]
,[LimitBackColour]
,@EnterDate
,@EnterTime
,@EnterUser
,[LimitText]
,[FilterName]
,0 --deleted
,0 --rule based
FROM TestLimits join Tests on Tests.TestCode=TestLimits.TestCode and Tests.AuditNumber= TestLimits.AuditNumber  WHERE Tests.TestCode=@TestCode and Tests.auditnumber=@TestVersion and ([TestLimits].FilterString is null or DATALENGTH([TestLimits].FilterString)=0)
END

Answer 1

Assuming that I understand your logic correctly (ie. that you want the nextlimitnumber to increase by 1 for each row being added), in Oracle, I'd do it by using the analytic function row_number() to work out what number to add to the previous max value, something like:

INSERT INTO sampletestlimits (auditnumber,
                              limitnumber,
                              componentrow,
                              componentcolumn,
                              componentname,
                              testposition,
                              samplecode,
                              auditflag,
                              limitsource,
                              limittype,
                              upperlimitentered,
                              upperlimitvalue,
                              lowerlimitentered,
                              lowerlimitvalue,
                              limittextcolour,
                              limitpattern,
                              limitforecolour,
                              limitbackcolour,
                              createddate,
                              createdtime,
                              createduser,
                              limittext,
                              filtername,
                              deleted,
                              isrulebased)
  SELECT 1, --starting auditnumber
         (SELECT COALESCE (MAX (limitnumber), 0) + 1 AS nextlimitnumber
          FROM   sampletestlimits
          WHERE      samplecode = p_samplecode
                 AND testposition = p_testposition
                 AND componentrow = 1
                 AND componentcolumn = 1
                 AND auditflag = 0)
           + row_number() over (partition by testposition, componentrow, componentcolumn, auditflag) as nextlimitnumber, -- TFS bug# 3952: Calculate next limit number.
         componentrow,
         componentcolumn,
         (SELECT componentname
          FROM   testcomponents tc
          WHERE      tc.testcode = p_testcode
                 AND tc.componentcolumn = testlimits.componentcolumn
                 AND tc.componentrow = testlimits.componentrow
                 AND tc.auditnumber = testlimits.auditnumber),
         p_testposition,
         p_samplecode,
         0, --auditflag
         1, --limitsource = test
         limittype,
         upperlimitentered,
         upperlimitvalue,
         lowerlimitentered,
         lowerlimitvalue,
         limittextcolour,
         limitpattern,
         limitforecolour,
         limitbackcolour,
         p_enterdate,
         p_entertime,
         p_enteruser,
         limittext,
         filtername,
         0, --deleted
         0  --rule based
  FROM   testlimits
         JOIN tests
           ON     tests.testcode = testlimits.testcode
              AND tests.auditnumber = testlimits.auditnumber
  WHERE      tests.testcode = p_testcode
         AND tests.auditnumber = p_testversion
         AND (   testlimits.filterstring IS NULL
              OR datalength (testlimits.filterstring) = 0);

I had to guess at what the partition by clause would need to contain - adjust that as necessary for your requirements.