So I'm making a program that decodes a coded message, it compiles but when I run it I get a java.lang.StringIndexOutOfBoundsException: String index out of range: 1 error and I can't figure out where this is coming from.
Here's the code:
import java.util.Scanner;
public class ReverseCodeProgram {
public static int i;
public static String decodeLetter(String s){
String a = "";
if ((s.charAt(0) == '.'))
a = "E";
if ((s.charAt(0) == '-'))
a = "T";
if ((s.charAt(0) == '-') && (s.charAt(1) == '-'))
a = "M";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.'))
a = "N";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.'))
a = "I";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-'))
a = "A";
if ((s.charAt(0) == ' ') && (s.charAt(1) == ' '))
a = " ";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-') && (s.charAt(2) == '.'))
a = "R";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.') && (s.charAt(2) == '.'))
a = "S";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.') && (s.charAt(2) == '-'))
a = "U";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '.'))
a = "D";
if ((s.charAt(0) == '-') && (s.charAt(1) == '-') && (s.charAt(2) == '.'))
a = "G";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '-'))
a = "K";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '-'))
a = "O";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-') && (s.charAt(2) == '-'))
a = "W";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '.') && (s.charAt(3) == '.'))
a = "B";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '-') && (s.charAt(3) == '.'))
a = "C";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.') && (s.charAt(2) == '-') && (s.charAt(3) == '.'))
a = "F";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.') && (s.charAt(2) == '.') && (s.charAt(3) == '.'))
a = "H";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-') && (s.charAt(2) == '-') && (s.charAt(3) == '-'))
a = "J";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-') && (s.charAt(2) == '.') && (s.charAt(3) == '.'))
a = "L";
if ((s.charAt(0) == '.') && (s.charAt(1) == '-') && (s.charAt(2) == '-') && (s.charAt(3) == '.'))
a = "P";
if ((s.charAt(0) == '-') && (s.charAt(1) == '-') && (s.charAt(2) == '.') && (s.charAt(3) == '-'))
a = "Q";
if ((s.charAt(0) == '.') && (s.charAt(1) == '.') && (s.charAt(2) == '.') && (s.charAt(3) == '-'))
a = "V";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '.') && (s.charAt(3) == '-'))
a = "X";
if ((s.charAt(0) == '-') && (s.charAt(1) == '.') && (s.charAt(2) == '-') && (s.charAt(3) == '-'))
a = "Y";
if ((s.charAt(0) == '-') && (s.charAt(1) == '-') && (s.charAt(2) == '.') && (s.charAt(3) == '.'))
a = "Z";
s = a;
return s;
}
public static void main(String[] args) {
System.out.println("Please enter the sentence in Morse code");
String code = new Scanner(System.in).nextLine();
String decodedCharacter = "", character = "", decodedCode = "";
for (i = 0; i < code.length(); i++){
if (code.charAt(i) == ' '){
for (int j = i - 4; j < i; j++){
character += code.charAt(j);
decodedCharacter = "" + decodeLetter(character);
}
decodedCode += decodedCharacter;
}
}
System.out.println(decodedCode);
}
}
for (int j = i - 4; j < i; j++)
The above line is causing your error. It's because i is less than 4 when it reaches that line. Try the following instead:
public static void main(String[] args) {
System.out.println("Please enter the sentence in Morse code");
String code[] = new Scanner(System.in).nextLine().split(" ");
String decodedCode = "";
for(String character : code){
decodedCode += decodeLetter(character);
}
System.out.println(decodedCode);
}
It splits the input into a string array by "character" and then iterates over it.
For your input, the exception happens at if ((s.charAt(0) == '.') && (s.charAt(1) == '.'))
where s
is just .
and you are trying to access second character of it.
You should have a change in your loop to read the characters:
for (i = 0; i < code.length(); i++) {
if (code.charAt(i) == ' ') {
character = ""; //Clear the value before read
for (int j = i - 4; j < i; j++) {
character += code.charAt(j);
}
decodedCharacter = decodeLetter(character); //This should be outside the for(int j = 1-4 loop for you to read the 4 chars and then pass to decode.
decodedCode += decodedCharacter;
}
}
The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.