Visual studio 2015 installer projects

Question

I'm try to do some validation inside OnBeforeInstall method & if the validation pass will continue through the installation process, if the validation failed i want to rollback and uninstall the setup.

i tried something like this, even though this is successfull, this gave me some exceptions while rollback.

if(validation){
}
else{
    base.RollBack(savedState);
}

Exception - savedState does not contain required values or corrupted.

Please help me to do this without any exceptions.

Answer 1

That's not really how to cause a Visual Studio-generated MSI to roll back. You throw an InstallException, and that results in a rollback.

OnBeforeInstall isn't actually "before" the install. All Visual Studio install custom actions are called after all the files are already installed (despite the name), so the rollback actually uninstalls everything. If you are validating input (or some pre-install conditions) it's rather unfriendly.