Below is the javaScript for login validation. but output always "Incorrect username or password" i.e else condition

Question

 var objLogin = [{ fname: "sastry", book: "sastry" }, { fname: "laxman", book: "laxman" }, { fname: "visali", book: "visali" }] function storeData() { var userName = document.getElementById("fname").Value; var userPasswd = document.getElementById("book").Value; for (i = 0; i < objLogin.length; i++) { if (userName == objLogin[i].fname && userPasswd == objLogin[i].book) { console.log(userName + "Is logged in!!"); return; } else { console.log("Incorrect username or password"); } } }

Answer 1

When accessing the value of an input field, you should use value (lower case "v").

var userName = document.getElementById("fname").value;

Also, it's great to cache your element references, like this:

const userNameInput = document.getElementById("fname");
const userPasswdInput = document.getElementById("book");

function storeData() {
    const userName = userNameInput.value;
    const userPasswd = userPasswdInput.value;

    for (i = 0; i < objLogin.length; i++) {
        if (userName === objLogin[i].fname && userPasswd === objLogin[i].book) {
            console.log(userName + "Is logged in!!");
            return;
        } else {
            console.log("Incorrect username or password");
        }
    }
}

Answer 2

I think there is some typo.

  var userName = document.getElementById("fname").Value;
  var userPasswd = document.getElementById("book").Value;

As far as I know, document.getElementById("something").value is right;

Oh, someone answer that, but it's my first time to use stack overflow, how can I do?