I am trying to solve the runoff problem of pset3 in cs50. We have to find the result of a election when the voters input the choice of first 3 preference of candidates.If their isn't a winner with more than 50% of 1st preference of votes then the candidate with the least number of votes is eliminated and looped until there is a winner.
#include <cs50.h>
#include <stdio.h>
#include <string.h>
// Max voters and candidates
#define MAX_VOTERS 100
#define MAX_CANDIDATES 9
// preferences[i][j] is jth preference for voter i
int preferences[MAX_VOTERS][MAX_CANDIDATES];
// Candidates have name, vote count, eliminated status
typedef struct
{
string name;
int votes;
bool eliminated;
}
candidate;
// Array of candidates
candidate candidates[MAX_CANDIDATES];
// Numbers of voters and candidates
int voter_count;
int candidate_count;
// Function prototypes
bool vote(int voter, int rank, string name);
void tabulate(void);
bool print_winner(void);
int find_min(void);
bool is_tie(int min);
void eliminate(int min);
int main(int argc, string argv[])
{
// Check for invalid usage
if (argc < 2)
{
printf("Usage: runoff [candidate ...]\n");
return 1;
}
// Populate array of candidates
candidate_count = argc - 1;
if (candidate_count > MAX_CANDIDATES)
{
printf("Maximum number of candidates is %i\n", MAX_CANDIDATES);
return 2;
}
for (int i = 0; i < candidate_count; i++)
{
candidates[i].name = argv[i + 1];
candidates[i].votes = 0;
candidates[i].eliminated = false;
}
voter_count = get_int("Number of voters: ");
if (voter_count > MAX_VOTERS)
{
printf("Maximum number of voters is %i\n", MAX_VOTERS);
return 3;
}
// Keep querying for votes
for (int i = 0; i < voter_count; i++)
{
// Query for each rank
for (int j = 0; j < candidate_count; j++)
{
string name = get_string("Rank %i: ", j + 1);
// Record vote, unless it's invalid
if (!vote(i, j, name))
{
printf("Invalid vote.\n");
return 4;
}
}
printf("\n");
}
// Keep holding runoffs until winner exists
while (true)
{
// Calculate votes given remaining candidates
tabulate();
// Check if election has been won
bool won = print_winner();
if (won)
{
break;
}
// Eliminate last-place candidates
int min = find_min();
bool tie = is_tie(min);
// If tie, everyone wins
if (tie)
{
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
printf("%s\n", candidates[i].name);
}
}
break;
}
// Eliminate anyone with minimum number of votes
eliminate(min);
// Reset vote counts back to zero
for (int i = 0; i < candidate_count; i++)
{
candidates[i].votes = 0;
}
}
return 0;
}
// Record preference if vote is valid
bool vote(int voter, int rank, string name)
{
for (int k = 0; k < candidate_count; k++)
{
if (strcmp(name, candidates[k].name) == 0)
{
preferences[voter][rank] = k;
return true;
}
}
return false;
}
// Tabulate votes for non-eliminated candidates
void tabulate(void)
{
for (int i = 0; i < voter_count; i++)
{
for (int j = 0; j < candidate_count; j++)
{
if (!candidates[j].eliminated)
{
candidates.votes[preferences[i][j]]++;
break;
}
}
}
return;
}
// Print the winner of the election, if there is one
bool print_winner(void)
{
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
if (candidates.votes[i] > (voter_count * 0.5))
{
printf("%s", candidates.name[i]);
return true;
}
}
}
return false;
}
// Return the minimum number of votes any remaining candidate has
int find_min(void)
{
int k = candidates[1].votes;
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
if (k > candidates[i].votes)
{
k = candidates[i].votes;
}
}
}
return k;
}
// Return true if the election is tied between all candidates, false otherwise
bool is_tie(int min)
{
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
if (candidates[i].votes != min)
return false;
}
}
return true;
}
// Eliminate the candidate (or candidates) in last place
void eliminate(int min)
{
for (int i = 0; i < candidate_count; i++)
{
if (!candidates[i].eliminated)
{
if (candidates[i].votes == min)
{
candidates[i].eliminated = true;
}
}
}
return;
}
When compiled it shows these errors
clang -ggdb3 -O0 -std=c11 -Wall -Werror -Wextra -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wshadow runoff.c -lcrypt -lcs50 -lm -o runoff
runoff.c:151:27: error: member reference base type 'candidate [9]' is not a structure or union
candidates.votes[preferences[i][j]]++;
~~~~~~~~~~^~~~~~
runoff.c:166:27: error: member reference base type 'candidate [9]' is not a structure or union
if (candidates.votes[i] > (voter_count * 0.5))
~~~~~~~~~~^~~~~~
runoff.c:168:40: error: member reference base type 'candidate [9]' is not a structure or union
printf("%s", candidates.name[i]);
I am not able to figure what's wrong.
In tabulate function, try changing this:
candidates.votes[preferences[i][j]]++;
to this:
candidates[preferences[i][j]].votes++;
In print_winner function, try changing this:
candidates.votes[i]
to this:
candidates[i].votes
and this:
printf("%s", candidates.name[i]);
to this:
printf("%s", candidates[i].name);
The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.