简体   繁体   中英

Deserializing JSON Response to C# object error

What I'm doing is an API call to and turn the response into a C# object. I'm trying to refactor my working code https://codereview.stackexchange.com/questions/253949/api-response-json-to-c-object/ . Into code that was suggested on codereview now I get the following error:

Newtonsoft.Json.JsonSerializationException: Cannot deserialize the current JSON array (e.g. [1,2,3]) into type 'Candlestick' because the type requires a JSON object (e.g. {"name":"
value"}) to deserialize correctly.
To fix this error either change the JSON to a JSON object (e.g. {"name":"value"}) or change the deserialized type to an array or a type that implements a collection interface (e.g. ICollection, IList) like List<T> that can be
 deserialized from a JSON array. JsonArrayAttribute can also be added to the type to force it to deserialize from a JSON array.

Json Response from API:

[
    [
        1609065000000,
        "22739.71000000",
        "22795.73000000",
        "22700.39000000",
        "22779.08000000",
        "38.81782800",
        1609065899999,
        "883167.94526884",
        2261,
        "18.58965200",
        "423036.58181400",
        "0"
    ]
]

    [System.Text.Json.Serialization.JsonConverter(typeof(CandlestickConverter))]
    public class Candlestick
    {
        public long OpenTime { get; set; }
        public double Open { get; set; }
        public double High { get; set; }
        public double Low { get; set; }
        public double Close { get; set; }
        public double Volume { get; set; }
        public long CloseTime { get; set; }
        public double QuoteAssetVolume { get; set; }
        public long NumberOfTrades { get; set; }
        public double TakerBuyBaseAssetVolume { get; set; }
        public double TakerBuyQuoteAssetVolume { get; set; }
    }
   public class CandlestickConverter : JsonConverter
    {
        public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
        {
            var candle = (Candlestick) value;
            serializer.Serialize(writer ,
                new[]
                {
                    candle.OpenTime,
                    candle.Open,
                    candle.High,
                    candle.Low,
                    candle.Close,
                    candle.Volume,
                    candle.CloseTime,
                    candle.QuoteAssetVolume,
                    candle.NumberOfTrades,
                    candle.TakerBuyBaseAssetVolume,
                    candle.TakerBuyQuoteAssetVolume
                });
        }

        public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
        {
            if (reader.TokenType == JsonToken.Null)
                return null;

            var candle = existingValue as Candlestick ?? new Candlestick();

            var array = JArray.Load(reader);
            
            candle.OpenTime = array.ElementAtOrDefault(0)?.ToObject<long>(serializer) ?? 0;
            candle.Open = array.ElementAtOrDefault(1)?.ToObject<double>(serializer) ?? 0;
            candle.High = array.ElementAtOrDefault(2)?.ToObject<double>(serializer) ?? 0;
            candle.Low = array.ElementAtOrDefault(3)?.ToObject<double>(serializer) ?? 0;
            candle.Close = array.ElementAtOrDefault(4)?.ToObject<double>(serializer) ?? 0;
            candle.Volume = array.ElementAtOrDefault(5)?.ToObject<double>(serializer) ?? 0;
            candle.CloseTime = array.ElementAtOrDefault(6)?.ToObject<long>(serializer) ?? 0;
            candle.QuoteAssetVolume = array.ElementAtOrDefault(7)?.ToObject<double>(serializer) ?? 0;
            candle.NumberOfTrades = array.ElementAtOrDefault(8)?.ToObject<long>(serializer) ?? 0;
            candle.TakerBuyBaseAssetVolume = array.ElementAtOrDefault(9)?.ToObject<double>(serializer) ?? 0;
            candle.TakerBuyQuoteAssetVolume = array.ElementAtOrDefault(10)?.ToObject<double>(serializer) ?? 0;

            return candle;
        }

        public override bool CanConvert(Type objectType)
        {
            return objectType == typeof(Candlestick);
        }
    }

Implementation of convertion:

    var jsonObjectResponse = await response.Content.ReadAsStringAsync();
    var candles = JsonConvert.DeserializeObject<List<Candlestick>>(jsonObjectResponse);

I also tried var candles = JsonConvert.DeserializeObject<List<Candlestick>>($"{{{jsonObjectResponse}}}");

This gave next errror: Newtonsoft.Json.JsonReaderException: Invalid property identifier character: [. Path '', line 1, position 1. Newtonsoft.Json.JsonReaderException: Invalid property identifier character: [. Path '', line 1, position 1.

The json response object is something I haven't worked with before. I got it working but I would like some cleaner code and I'm trying to make it work as suggested as in the link I provided. Anyone got any idea what a solve would be or where I can find some more information?

@TomekSzpakowicz gave me the answer in his comment. I had to register the custom converter so I added the following code in my start up file.

            JsonConvert.DefaultSettings = () => new JsonSerializerSettings
            {
                Converters = new List<JsonConverter>
                {
                    new CandlestickConverter(),
                }
            };

The technical post webpages of this site follow the CC BY-SA 4.0 protocol. If you need to reprint, please indicate the site URL or the original address.Any question please contact:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM