Static variable bug in Java

Question

I have written a simple class and 3 tests as follows:

Person.java:

package MyPackage;

public class Person {
    
    private static int PERSON_COUNTER = 0;
    
    public Person() {
        PERSON_COUNTER++;
    }
    
    public String hello(){
        return "Hello World";
    }
    
    public String helloName(String name) {
        return "Hello "+name;
    }
    
    public static int numberOfPersons() {
        return PERSON_COUNTER;
    }
    
}

---

PersonTest.java:

---

package Test;

import static org.junit.Assert.assertEquals;

import org.junit.Test;

import MyPackage.Person;

public class PersonTest {
    
    @Test
    public void testHello() {
        Person p = new Person();
        assertEquals("Hello World",p.hello());
    }
    
    @Test
    public void testHelloName() {
        Person p1 = new Person();
        assertEquals("Hello Mile",p1.helloName("Mile"));
    }
    
    @Test
    public void numberOfPersons() {
        Person p2 = new Person();
        Person p3 = new Person();
        Person p4 = new Person();
        assertEquals(3, Person.numberOfPersons());
    }
}

The test numberOfPersons fails with message: java.lang.AssertionError: expected:<3> but was:<4> The fourth object person is being counted from testHello test and I don't seem to find reason why is that happening.

Answer 1

You should use a method with the annotation @BeforeEach, that cleans your environment by resetting the variables, I think this is what you are missing.