Unable to get values from SQLite database using Android Studio 2.1

Question

I'm trying to use SQLite to set up a database to store username's and password's, but whenever I register for an account on the emulator it errors out. Also if I just try to login without registering it will error out. This is only my second post so if there is anything I can do better when posting let me know!

public class DbHelper extends SQLiteOpenHelper {
private static String DbName = "SimpleDatabase";
private static int DbVersion = 1;

//Table Names
private static final String TABLE_USER = "User";

//Column Names
private static final String USER_NAME = "UserName";
private static final String PASSWORD = "Password";

//Create statements
// Todo table create statement
private static final String CREATE_TABLE_USER = "CREATE TABLE " 
        + TABLE_USER + "(" + USER_NAME + "TEXT PRIMARY KEY," 
        + PASSWORD + "TEXT)" ;

public DbHelper(Context context) {
    super(context, DbName, null, DbVersion);
}


@Override
public void onCreate(SQLiteDatabase db) {
    db.execSQL(CREATE_TABLE_USER);
}

@Override
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
    db.execSQL("DROP TABLE IF EXIST "+TABLE_USER);
    onCreate(db);
}

public Boolean InsertUser(String userName,String password){
    SQLiteDatabase db = this.getWritableDatabase();

    String query = "SELECT * FROM "+TABLE_USER+" WHERE "+USER_NAME+" == '"+userName+"';";
    Cursor c = db.rawQuery(query,null);
    if(c != null && c.moveToFirst()) {
        c.close();
        return false ;

    }else{
        ContentValues values = new ContentValues();
        values.put(USER_NAME, userName);
        values.put(PASSWORD, password);

        db.insert(TABLE_USER, null, values);
        return true;
    }
}

public Boolean loginUser(String userName,String password){

    SQLiteDatabase db = this.getWritableDatabase();
    String query = "SELECT * FROM "+TABLE_USER+" WHERE "+USER_NAME+" == '"+userName+"' AND "+PASSWORD+" == '"+password+"';";
    Cursor c = db.rawQuery(query,null);
    if(c != null && c.moveToFirst()) {
        c.close();
        return true;
    }
    return false;
}

}

Here is the LOGIN class that goes with the DbHelper

public class Login extends Fragment {

TextInputLayout usernamelayout, passwordLayout;
EditText userName,password;
Button login, goToRegister;
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    return inflater.inflate(R.layout.content_login,container,false);
}

@Override
public void onViewCreated(final View view, Bundle savedInstanceState) {
    super.onViewCreated(view, savedInstanceState);
    usernamelayout = (TextInputLayout)view.findViewById(R.id.user_name_layout);
    passwordLayout = (TextInputLayout)view.findViewById(R.id.password_layout);
    userName = (EditText)view.findViewById(R.id.user_name);
    password = (EditText)view.findViewById(R.id.password);
    login = (Button)view.findViewById(R.id.login_button);
    login.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            String userText = userName.getText().toString().trim();
            String passwordText = password.getText().toString().trim();
            if (userText.isEmpty()) {
                usernamelayout.setErrorEnabled(true);
                usernamelayout.setError("Please Enter User Name");

            } else if (passwordText.isEmpty()) {
                passwordLayout.setErrorEnabled(true);
                passwordLayout.setError("Please Enter Password");
            } else {
                DbHelper helper = new DbHelper(getActivity());
                if (helper.loginUser(userText, passwordText)) {
                    startActivity(new Intent(getActivity(), MainActivity.class));
                } else {
                    Toast.makeText(getActivity(), "User Name or Password is incorrect", Toast.LENGTH_SHORT).show();
                }
            }
        }
    });
    goToRegister = (Button)view.findViewById(R.id.go_to_register_button);
    goToRegister.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            Register fragment = new Register();
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP){
                setSharedElementReturnTransition(TransitionInflater.from(getActivity()).inflateTransition(R.transition.change_image_trans));
                setExitTransition(TransitionInflater.from(getActivity()).inflateTransition(android.R.transition.fade) );
                fragment.setSharedElementEnterTransition(TransitionInflater.from(getActivity()).inflateTransition(R.transition.change_image_trans));
                fragment.setEnterTransition(TransitionInflater.from(getActivity()).inflateTransition(android.R.transition.fade));

            }

            FragmentTransaction transaction = getActivity().getSupportFragmentManager().beginTransaction();
            transaction.addSharedElement(view.findViewById(R.id.logo),"LOGO");
            transaction.replace(R.id.main_container, fragment);
            transaction.commit();
        }
    });
}

@Override
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);
    getActivity().setTitle("Uhvents Login");
}

}

Here is the REGISTER class.

public class Register extends Fragment {

TextInputLayout usernamelayout, passwordLayout;
EditText userName,password;
Button register, goToLogin;
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    return inflater.inflate(R.layout.content_register,container,false);
}
@Override
public void onViewCreated(final View view, Bundle savedInstanceState) {
    super.onViewCreated(view, savedInstanceState);
    usernamelayout = (TextInputLayout) view.findViewById(R.id.user_name_layout);
    passwordLayout = (TextInputLayout) view.findViewById(R.id.password_layout);
    userName = (EditText) view.findViewById(R.id.user_name);
    password = (EditText) view.findViewById(R.id.password);

    register = (Button) view.findViewById(R.id.register_button);
    register.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            String userText = userName.getText().toString().trim();
            String passwordText = password.getText().toString().trim();
            if(userText.isEmpty()) {
                usernamelayout.setErrorEnabled(true);
                usernamelayout.setError("Please Enter User Name");

            }
            else if (passwordText.isEmpty()){
                passwordLayout.setErrorEnabled(true);
                passwordLayout.setError("Please Enter Password");

            }
            else {

                DbHelper helper = new DbHelper(getActivity());
                if (helper.InsertUser(userText,passwordText)){
                    Toast.makeText(getActivity(), "Registration Success", Toast.LENGTH_SHORT).show();
                    if (getActivity().getResources().getConfiguration().orientation == Configuration.ORIENTATION_PORTRAIT)
                    {
                        goToLogin.performClick();
                    }
                }else {
                    Toast.makeText(getActivity(), "User Name already in use.",Toast.LENGTH_SHORT).show();
                }
            }
        }
    });
    goToLogin = (Button)view.findViewById(R.id.go_to_login);
    goToLogin.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

            Login fragment = new Login();
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP){
                    setSharedElementReturnTransition(TransitionInflater.from(getActivity()).inflateTransition(R.transition.change_image_trans));
                    setExitTransition(TransitionInflater.from(getActivity()).inflateTransition(android.R.transition.fade) );
                    fragment.setSharedElementEnterTransition(TransitionInflater.from(getActivity()).inflateTransition(R.transition.change_image_trans));
                    fragment.setEnterTransition(TransitionInflater.from(getActivity()).inflateTransition(android.R.transition.fade));

            }

            FragmentTransaction transaction = getActivity().getSupportFragmentManager().beginTransaction();
            transaction.addSharedElement(view.findViewById(R.id.logo),"LOGO");
            transaction.replace(R.id.main_container, fragment);
            transaction.commit();
        }

});
}
@Override
public void onActivityCreated(@Nullable Bundle savedInstanceState) {
    super.onActivityCreated(savedInstanceState);
    getActivity().setTitle("Register for Uhvents");
}

}

And then here is the error log that I'm getting whenever I run the scenario depicted above.

FATAL EXCEPTION: main Process: com.uhdapt.tutorial4, PID: 4807 android.database.sqlite.SQLiteException: no such column: UserName (code 1): , while compiling: SELECT * FROM User WHERE UserName == 'alex' AND Password == '1234' at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method) at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:887) at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:498) at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:588) at android.database.sqlite.SQLiteProgram.(SQLiteProgram.java:58) at android.database.sqlite.SQLiteQuery.(SQLiteQuery.java:37) at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:44) at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1316) at android.database.sqlite.SQLiteDatabase.rawQuery(SQLiteDatabase.java:1255) at com.uhdapt.tutorial4.database.DbHelper.loginUser(DbHelper.j ava:68) at com.uhdapt.tutorial4.fragments.Login$1.onClick(Login.java:63) at android.view.View.performClick(View.java:5198) at android.view.View$PerformClick.run(View.java:21147) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:5417) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Answer 1

You need to add space in your concatenation.

This parts have no space

" + USER_NAME + "TEXT PRIMARY KEY,"

and this

+ PASSWORD + "TEXT)";

So change it to

private static final String CREATE_TABLE_USER = "CREATE TABLE " 
        + TABLE_USER + "(" + USER_NAME + " TEXT PRIMARY KEY," 
        + PASSWORD + " TEXT)";

Answer 2

The exception stack trace contains column name UserName that can not be found in the User table in SQLite database:

android.database.sqlite.SQLiteException: no such column: UserName (code 1): , while compiling: SELECT * FROM User WHERE UserName == 'alex' AND Password == '1234'

To fix that problem, your database helper class needs to be changed as follows:

public class DbHelper extends SQLiteOpenHelper {

    private static final String DbName = "SimpleDatabase";
    private static final int DbVersion = 1;

    // Table Names
    private static final String TABLE_USER = "User";

    // Column Names
    private static final String USER_NAME = "UserName";
    private static final String PASSWORD = "Password";

    // Create statements
    // Todo table create statement
    private static final String CREATE_TABLE_USER = "CREATE TABLE " 
            + TABLE_USER + " (" + USER_NAME + " TEXT PRIMARY KEY,"   
            // >>>>>> Note extra space above before TEXT keyword
            + PASSWORD + " TEXT)" ;

    public DbHelper(Context context) {
        super(context, DbName, null, DbVersion);
    }


    @Override
    public void onCreate(SQLiteDatabase db) {
        db.execSQL(CREATE_TABLE_USER);
    }

    @Override
    public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
        db.execSQL("DROP TABLE IF EXIST "+TABLE_USER);
        onCreate(db);
    }

    public Boolean InsertUser(String userName,String password){
        SQLiteDatabase db = this.getWritableDatabase();

        String query = "SELECT * FROM "+TABLE_USER+" WHERE "+USER_NAME+" == '"+userName+"';";
        Cursor c = db.rawQuery(query,null);

        if (c != null && c.moveToFirst()) {
            c.close();
            return false ;
        } else {
            ContentValues values = new ContentValues();
            values.put(USER_NAME, userName);
            values.put(PASSWORD, password);

            db.insert(TABLE_USER, null, values);
            return true;
        }
    }

    public Boolean loginUser(String userName,String password){

        SQLiteDatabase db = this.getWritableDatabase();
        String query = "SELECT * FROM " + TABLE_USER + 
        " WHERE "+USER_NAME+" ==    '"+userName+"' AND "
        + PASSWORD + " == '"+password+"';";

        Cursor c = db.rawQuery(query,null);

        if(c != null && c.moveToFirst()) {
                c.close();
                return true;
        }

        return false;
    }
}