using generics in c# extension functions

Question

I am using generics to translate Java code to C# and having trouble with containers of the sort:

public static class MyExtensions
{
    public static void add(this List<object> list, object obj)
    {
        list.Add(obj);
    }
    public static void add(this List<string> list, string s)
    {
        list.Add(s);
    }
}

It seems that the generics are lost in comparing arguments and the two methods collide. I'd like any advice on whether generics can be used in this way. Is it possible to support all list operations with a single:

    public static void add(this List<object> list, object obj)
    {
        list.Add(obj);
    }

for example?

SUMMARY All responses have the same solution. List can be abstracted to ICollection. Overall it's probably not a good idea for production code.

Answer 1

How about:

public static void add<T>(this IList<T> list, T value)
{
    list.Add(value);
}

(actually, it could be ICollection<T> , since this (not IList<T> ) defines Add(T) )

Answer 2

Have you tried:

public static void add<T>(this List<T> list, T obj)
{
    list.Add(obj);
}

I'm not sure if you'd want to constrain it to a class or not, but that should do what you're describing.

Answer 3

Do you mean this:

public static void add<T>(this List<T> list, T obj)
{
    list.Add(obj);
}

Answer 4

I think Marc Gravell answered this best , but I will add:

Don't do this at all. There is no advantage to:

myList.add(obj);

vs

myList.Add(obj);

The only "advantage" here is that your resulting C# will look wrong to most developers. If you're going to port from Java to C#, it's worth taking the extra time to make your methods look and work like native .NET methods.

Answer 5

The most versatile way:

public static void add<T>(this ICollection<T> list, T obj) // use ICollection<T>
{
    list.Add(value);
}

Answer 6

@Dreamwalker, did you mean? list.Add(obj);