android lazy load gallery issue

Question

im trying to asyncronously download some images in an asynctask and then in the onPostExecute() set the images to a gallery adapter. I have hard coded the images to be donwloaded in the asyntask since I cant even get to the part where i will be passing the images to the constructor of the adapter :/ No errors are thrown and the postexecute Log() doesnt post anything to logcat

Can anybody tell me where I am going wrong please?

public class GallerythreadedtestActivity extends Activity {

private Gallery gallery;
private AddImgAdp adapter;
private Drawable[] image;
@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.main);
    new downloadImages().execute();
}

public class AddImgAdp extends BaseAdapter {
    int GalItemBg;
    private Context cont;

    // Adding images.
    private Integer[] Imgid = {
    R.drawable.icon, R.drawable.icon, R.drawable.icon, R.drawable.icon
    };

    public AddImgAdp(Context c) {
    cont = c;
    TypedArray typArray = obtainStyledAttributes(R.styleable.GalleryTheme);
    GalItemBg = typArray.getResourceId(R.styleable.GalleryTheme_android_galleryItemBackground, 0);
    typArray.recycle();
    }

    public int getCount() {
    return Imgid.length;
    }

    public Object getItem(int position) {
    return position;
    }

    public long getItemId(int position) {
    return position;
    }

    public View getView(int position, View convertView, ViewGroup parent) {
    ImageView imgView = new ImageView(cont);

    imgView.setImageDrawable(image[position]);
    // Fixing width & height for image to display
    imgView.setLayoutParams(new Gallery.LayoutParams(80, 70));
    imgView.setScaleType(ImageView.ScaleType.FIT_XY);
    imgView.setBackgroundResource(GalItemBg);

    return imgView;
    }
    }

public class downloadImages extends AsyncTask<String, Void, Void> {

    protected void onPreExecute(){
        image=new Drawable[2];
        adapter = new AddImgAdp(getApplicationContext());
        gallery = (Gallery) findViewById(R.id.examplegallery);
    }

    protected void onProgressUpdate(Void... v){

    }

    protected Void doInBackground(final String... args) {


        image[0] = ImageOperations(getApplicationContext(),"http://t3.gstatic.com/images?q=tbn:ANd9GcQidl6KX2jRWNeCA6jT_TjWG7NlI3aRiB_AcDsA9Y5owS2cr9G6","image.jpg");
        image[1] = ImageOperations(getApplicationContext(),"http://t3.gstatic.com/images?q=tbn:ANd9GcQidl6KX2jRWNeCA6jT_TjWG7NlI3aRiB_AcDsA9Y5owS2cr9G6","image.jpg");

        return null;

    }

    protected void onPostExecute(){
        Log.d("onpost","");
        gallery.setAdapter(adapter);
        gallery.setOnItemClickListener(new OnItemClickListener() {
            public void onItemClick(AdapterView parent, View v, int position, long id) {
            Toast.makeText(GallerythreadedtestActivity.this, "Position=" + position, Toast.LENGTH_SHORT).show();
            }
            });
    }

}

private Drawable ImageOperations(Context ctx, String url, String saveFilename) {
    try {
        InputStream is = (InputStream) this.fetch(url);
        Drawable d = Drawable.createFromStream(is, "src");
        return d;
    } catch (MalformedURLException e) {
        e.printStackTrace();
        return null;
    } catch (IOException e) {
        e.printStackTrace();
        return null;
    }
}

public Object fetch(String address) throws MalformedURLException,IOException {
    URL url = new URL(address);
    Object content = url.getContent();
    return content;
}

}

Answer 1

I can give you a suggestion please try this also as an supplementary solution, its better lazy load the images: Lazy load of images in ListView . In that if you change the list view element in the xml to Gallery view, I think that will solve your issue.